Fix wave: dropdown keyboard/focus, appearance resets, inline key editors, content-sized slider

- MenuShell: after placement, focus lands in the search when the menu has
  one, else the body (tabIndex -1) — the lists' mount-time focus ran during
  the hidden measuring pass and silently failed, so no dropdown ever opened
  focused. The body owns the arrow machine for searchless menus:
  ArrowDown/Up cycle options with wrap (first/last entry from the body,
  native-select convention), Home/End, Enter activates, preventDefault so
  arrows never scroll the page.
- Appearance: the CSS-var applier only ever setProperty'd — a later write
  omitting a var left the stale inline value forever (empty background
  never reset, serif toggle-back looked dead). appliedNamesRef tracks what
  was set; staleVarNames (pure, exported) returns what to removeProperty.
- CommitInput: controlled — after a commit the field snaps to the stored
  record, so the clamp on a -5 prose size is visible (12), Esc reverts.
- Keys: Add-provider dropdown closes on pick; the paste row is inline
  (label | input | Save | Cancel); existing-row editors go inline with an
  explicit Cancel beside Save/Delete — folding is visible, not Esc-only.
- Graph context: readout is content-sized (tabular-nums) — no fixed-width
  dead gap when "off"; the dictation strip fills whatever space remains.

Gates: tsc clean, 866/866 tests (new staleVarNames suite), lint 0, build ok.
Live-verified via Playwright: dropdown focus+arrow cycles+wrap+Enter pick,
background set→empty reset, serif round-trip, visible clamp to 12, provider
pick closes menu, inline editor + Cancel + Esc fold, slider width 270→277px.
This commit is contained in:
amosblomqvist
2026-09-23 00:57:28 +03:00
parent b18294948d
commit 22266973f3
6 changed files with 224 additions and 51 deletions
+52
View File
@@ -125,6 +125,7 @@ export function MenuShell({
}) {
const menuRef = useRef<HTMLDivElement>(null);
const [placed, setPlaced] = useState<MenuPlacement | null>(null);
const focusedOnceRef = useRef(false);
// Announce open↔close for lockable surfaces (see MENU_OPEN_EVENT).
useEffect(() => {
@@ -134,6 +135,55 @@ export function MenuShell({
};
}, []);
// Focus on open (owner, fix wave): the search menus land focus IN the
// search; menus without one land it on the body (tabIndex -1 below) so
// the arrow machine has a home. Once only — re-placements (scroll/
// resize) must never steal focus back mid-walk. The lists' own mount
// focus runs during the hidden measuring pass, where focus() silently
// fails (visibility: hidden subtrees are not focusable) — this seam is
// the one that actually lands.
useEffect(() => {
if (placed === null || focusedOnceRef.current) return;
focusedOnceRef.current = true;
const el = menuRef.current;
if (!el) return;
const input = el.querySelector<HTMLElement>("input");
(input ?? el).focus();
}, [placed]);
// The standard arrow machine for menus WITHOUT a search (owner: when a
// dropdown is expanded, the arrow keys cycle the options and never
// scroll the screen): ArrowDown/Up move DOM focus among the option
// buttons with WRAP, Home/End hit the ends; Enter activates the
// focused button natively. Search menus own their arrows inside the
// input (their clamped-walk machine, 2026-09-17) — those events never
// bubble here, and the input/textarea guard is belt-and-braces.
const onBodyKeyDown = (e: React.KeyboardEvent<HTMLDivElement>) => {
if (e.target instanceof HTMLInputElement || e.target instanceof HTMLTextAreaElement) return;
const { key } = e;
if (key !== "ArrowDown" && key !== "ArrowUp" && key !== "Home" && key !== "End") return;
const buttons = Array.from(
menuRef.current?.querySelectorAll<HTMLElement>("button:not([disabled])") ?? [],
);
if (buttons.length === 0) return;
e.preventDefault();
if (key === "Home") {
buttons[0]?.focus();
return;
}
if (key === "End") {
buttons[buttons.length - 1]?.focus();
return;
}
const delta = key === "ArrowDown" ? 1 : -1;
const idx = buttons.findIndex((b) => b === document.activeElement);
// From the body (nothing focused yet): ArrowDown enters at the FIRST
// option, ArrowUp at the last — the native-select convention.
const base = idx === -1 ? (delta > 0 ? -1 : 0) : idx;
const next = (base + delta + buttons.length) % buttons.length;
buttons[next]?.focus();
};
const anchor = () => {
if (anchorRef) return anchorRef.current;
if (anchorTestid !== undefined) return document.querySelector(`[data-testid="${anchorTestid}"]`);
@@ -193,6 +243,8 @@ export function MenuShell({
ref={menuRef}
data-testid={testid}
data-lh-menu=""
tabIndex={-1}
onKeyDown={onBodyKeyDown}
style={{ position: "fixed", zIndex: 60, ...placed.style, maxHeight: placed.maxHeight, overflowY: "auto" }}
className={menuClass}
>