chains-primary: stored chains replace typed edges; edges become a derived view

Owner rulings 2026-09-30: reasoning chains are the stored truth; the graph
canvas renders a lossy derived image. No migration, no backcompat — old
graph data was wiped.

- contracts: GraphChain (arg_-minted id, premises, conclusion) replaces
  typed edges; GraphEdge survives only as the untyped derived arrow;
  GraphSnapshot carries stored chains; supports edges retired entirely
- store: chains.jsonl ledger (edges.jsonl purged at load alongside legacy
  events.jsonl); readChains/appendChain seam; merge dedupes by
  (sorted premises, conclusion), re-assertions append under the same arg_ id
- core: deriveView mints implication nodes (name ⟹, statement via
  formatChainLine) plus premise→imp→conclusion arrows; clusters stay
  proposition-only (birthSessionPartition); chainsForSelection now groups
  STORED chains (chain rides iff every member selected) — independent
  arguments for one conclusion never union; chainsToGraph/chainsToEdges die
- extraction: extractor submits chains natively (expandFindings deleted);
  auditor receives propositions only; supports fan-out gone
- deletion: full death of a proposition kills every referencing chain;
  arg_-prefixed node deletes kill that chain; chainsRemoved stats
- UI: every arrow renders the ⟹ double shaft; supports toggle + thickness
  slider and detail-card edge sections deleted (card keeps name +
  proposition); chain table + practice pipeline read stored chains
- tests: 1188 green across the new seams
This commit is contained in:
amosblomqvist
2026-09-30 03:22:52 +03:00
parent a3aabb3a57
commit 4985b6f9fa
28 changed files with 669 additions and 726 deletions
+11 -10
View File
@@ -27,18 +27,18 @@ import {
type RunningPractice,
} from "../src/agent/subagents/practice-pipeline.ts";
import { chainCoverage } from "../src/core/practice.ts";
import type { GraphEdge, GraphNode, ProblemSet } from "../src/core/contracts.ts";
import type { GraphChain, GraphNode, ProblemSet } from "../src/core/contracts.ts";
import type { ChatStore, GraphStore, PracticeStore } from "../src/core/ports.ts";
import { ModelsNotConfiguredError } from "../src/core/settings.ts";
// ─── in-memory stores ────────────────────────────────────────────────────────
function memoryGraph(nodes: GraphNode[], edges: GraphEdge[]): GraphStore {
function memoryGraph(nodes: GraphNode[], chains: GraphChain[]): GraphStore {
return {
appendNode: () => {},
readNodes: () => nodes.map((n) => ({ ...n, provenance: [...n.provenance], aliases: [...n.aliases] })),
appendEdge: () => {},
readEdges: () => edges.map((e) => ({ ...e, provenance: [...e.provenance] })),
appendChain: () => {},
readChains: () => chains.map((c) => ({ ...c, premises: [...c.premises], provenance: [...c.provenance] })),
appendCheckpoint: () => {},
readCheckpoints: () => [],
appendCoverage: () => {},
@@ -284,15 +284,16 @@ function diamondGraph(): GraphStore {
createdAt: NOW,
provenance: pt("chat_1"),
});
const edge = (from: string, to: string, type: "follows" | "supports" = "follows"): GraphEdge => ({
from,
to,
type,
const chain = (from: string, to: string): GraphChain => ({
id: to, // fixture id = conclusion id (the form the generator prompt renders)
premises: [from],
conclusion: to,
provenance: pt("chat_1"),
createdAt: NOW,
});
return memoryGraph(
[node("a", "A"), node("b", "B"), node("c", "C"), node("d", "D"), node("e", "E")],
[edge("a", "b"), edge("a", "c"), edge("b", "d"), edge("c", "d")],
[chain("a", "b"), chain("a", "c"), { id: "d", premises: ["b", "c"], conclusion: "d", provenance: pt("chat_1"), createdAt: NOW }],
);
}
@@ -372,7 +373,7 @@ describe("createProblemSet (generation)", () => {
assert.match(set.id, /^ps_/);
assert.equal(set.status, "partitioning");
assert.equal(set.title, "Practice — 2026-09-29"); // nodeIds path: dated fallback title
assert.equal(set.title, `Practice — ${new Date().toISOString().slice(0, 10)}`); // nodeIds path: dated fallback title
// Stubs appear the moment the partition lands — numbered, generating.
await until(() => f.practice.store.getSet(set.id)?.status === "generating");