sorokin.oleg.edu/learnharness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 7 Wiki Activity

Fix ⌘B: dispatch/listen event-name mismatch; thinking pill → "Thinking (⇧⇥)"

Browse Source 
Root cause (interlude, owner 2026-09-25): keyboard-shortcuts dispatches
registry actions on the lh:kbd-<action> convention, but the sidebar's
listener sat on the pre-convention name "lh:toggle-sidebar" — a name
nothing ever dispatches, so ⌘B silently did nothing while its tooltip
and cheat-sheet row kept claiming the binding. A sweep of every lh:
listener confirmed the sidebar was the lone stray (chat-renamed and
graph-revision are deliberate non-kbd events).

Fix, structural: kbdEventForAction(action) exported from
src/core/keyboard.ts — the ONE spelling — and both sides compose
through it (dispatcher's default branch, sidebar's toggle listener);
keyboard-shortcuts re-exports the helper so the contract pin can assert
no second spelling exists. The mismatch is now impossible by
construction.

Thinking pill: label trimmed to "Thinking" with its real shortcut via
the registry-composition path — "Thinking (⇧⇥)" (cycle-thinking,
rebind-live like every Hint suffix).

Pins (tests/keyboard-toggle-sidebar.test.ts): the full chain — mod+b →
actionForBinding → toggle-sidebar → kbdEventForAction →
lh:kbd-toggle-sidebar; formatBinding("shift+tab") → ⇧⇥; the
dispatcher-imports-the-same-helper contract.

Live-verified on :3001: ⌘B visually toggles on home, /chat/[id], and
/chat/new (sidebar 0↔288px, hamburger slot 0↔36); with the rebind
lh:keymap {"toggle-sidebar":"mod+j"}: ⌘J toggles and ⌘B is inert
(rebind-live); thinking pill renders "Thinking (⇧⇥)"; keymap restored,
sidebar left open.
This commit is contained in:
amosblomqvist
2026-09-25 02:39:11 +03:00
parent 6b83d3248b
commit b3c07f89f4
5 changed files with 85 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/sidebar.tsx
+10 -4
View File
@@ -18,6 +18,7 @@ import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { cn } from "@/lib/utils";
import type { ChatListItem } from "@/src/core";
import { kbdEventForAction } from "@/src/core";
/**
* Toggleable sidebar — NOT a modal drawer: no backdrop, no focus theft. It
@@ -118,12 +119,17 @@ export function SidebarProvider({ children }: { children: React.ReactNode }) {
});
}, [narrow, open]);
// ⌘B (keyboard wave A): the global shortcut dispatches lh:toggle-sidebar;
// the context is the one place that owns open state, so it listens here.
// ⌘B: the global shortcut dispatches kbdEventForAction("toggle-sidebar")
// and the context answers on exactly that name — the shared spelling
// is the fix for the interlude bug (the listener sat on the pre-
// convention name "lh:toggle-sidebar" while the dispatcher sent
// "lh:kbd-toggle-sidebar", so ⌘B silently did nothing; owner
// 2026-09-25).
useEffect(() => {
const event = kbdEventForAction("toggle-sidebar");
const onToggle = () => toggle();
window.addEventListener("lh:toggle-sidebar", onToggle);
return () => window.removeEventListener("lh:toggle-sidebar", onToggle);
window.addEventListener(event, onToggle);
return () => window.removeEventListener(event, onToggle);
}, [toggle]);
return (