fix: multi-select Other coexistence + the malformed-assessment probe-done crash
Two live bugs from the modal-realism stress runs: 1. Multi-select ask: picking the custom 'Other…' row cleared every already-picked option, and picking any option cleared a typed custom answer — single-select displacement logic applied to both modes. The dock's selection is now a pure state machine in question-core (toggleOption/toggleOther over DockSelection, unit-tested): single displaces (unchanged), multi coexists — neither channel clears the other; the typed text always survives. 2. ProbeDoneCard crashed on a REJECTED probe_done call: the model stringified 'assessment' (the same double-encoding habit as the options bug), zod rejected the call, the model retried — but the card's input-preview fallback trusted the errored part's unvalidated input shape and died on assessment.strands.map. The preview now reads input only while the call is pending or streaming (guarded with Array.isArray); an output-error part renders a quiet malformed-and-retried note instead of the garbage. Pinned: question-core.test.ts (3 dock-selection machine cases), render-cards.test.tsx (4 probe-done card cases incl. the exact live stringified shape, plus the multi-select ask markup pin). Gates: tsc, lint, build, 315/315.
This commit is contained in:
amosblomqvist
@@ -19,6 +19,9 @@ import {
|
||||
quizInputProblems,
|
||||
quizInputSchema,
|
||||
resolveCorrect,
|
||||
toggleOption,
|
||||
toggleOther,
|
||||
emptyDockSelection,
|
||||
shuffleOptions,
|
||||
type QuestionData,
|
||||
toClientQuestion,
|
||||
@@ -434,3 +437,50 @@ describe("makeId", () => {
|
||||
assert.equal(ids.size, 200);
|
||||
});
|
||||
});
|
||||
|
||||
// ─── the dock selection state machine (multi-select Other coexistence) ──
|
||||
// The live bug: in a multi-select ask, picking the custom "Other…" row
|
||||
// cleared every already-picked option (single-select displacement logic
|
||||
// applied to both modes). The machine lives here, pure and pinned.
|
||||
describe("dock selection (toggleOption / toggleOther)", () => {
|
||||
it("multi-select: options and Other coexist — neither clears the other", () => {
|
||||
let sel = emptyDockSelection();
|
||||
sel = toggleOption("multi-select", sel, 0);
|
||||
sel = toggleOption("multi-select", sel, 1);
|
||||
assert.deepEqual([...sel.selected], [0, 1]);
|
||||
// Picking Other keeps the sibling selections.
|
||||
sel = toggleOther("multi-select", sel);
|
||||
assert.deepEqual([...sel.selected], [0, 1], "Other never clears picked options");
|
||||
assert.equal(sel.otherSelected, true);
|
||||
// Picking another option keeps Other selected.
|
||||
sel = toggleOption("multi-select", sel, 2);
|
||||
assert.equal(sel.otherSelected, true, "options never clear a typed custom answer");
|
||||
assert.deepEqual([...sel.selected], [0, 1, 2]);
|
||||
// Deselecting an option toggles it alone.
|
||||
sel = toggleOption("multi-select", sel, 0);
|
||||
assert.deepEqual([...sel.selected], [1, 2]);
|
||||
// Other toggles off alone; the siblings survive.
|
||||
sel = toggleOther("multi-select", sel);
|
||||
assert.equal(sel.otherSelected, false);
|
||||
assert.deepEqual([...sel.selected], [1, 2]);
|
||||
});
|
||||
|
||||
it("multi-select: any selection clears dont-know", () => {
|
||||
let sel = { selected: new Set<number>(), otherSelected: false, dontKnow: true };
|
||||
sel = toggleOption("multi-select", sel, 0);
|
||||
assert.equal(sel.dontKnow, false);
|
||||
sel = toggleOther("multi-select", sel);
|
||||
assert.equal(sel.dontKnow, false);
|
||||
});
|
||||
|
||||
it("single-select: displacement semantics are unchanged", () => {
|
||||
let sel = emptyDockSelection();
|
||||
sel = toggleOption("single-select", sel, 0);
|
||||
sel = toggleOther("single-select", sel);
|
||||
assert.deepEqual([...sel.selected], [], "Other displaces the picked option");
|
||||
assert.equal(sel.otherSelected, true);
|
||||
sel = toggleOption("single-select", sel, 1);
|
||||
assert.equal(sel.otherSelected, false, "an option displaces Other");
|
||||
assert.deepEqual([...sel.selected], [1]);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -17,6 +17,7 @@ import { describe, it } from "node:test";
|
||||
import { renderToStaticMarkup } from "react-dom/server";
|
||||
import { MessageResponse } from "../components/ai-elements/message.tsx";
|
||||
import { QuestionDock } from "../components/question-dock.tsx";
|
||||
import { ProbeDoneCard } from "../components/artifacts/probe-done-card.tsx";
|
||||
import { AnsweredCard } from "../components/answered-card.tsx";
|
||||
import { buildAnswer, coerceCorrectAnswer, normalizeOptions, resolveCorrect, type QuestionData } from "../src/core/question-core.ts";
|
||||
|
||||
@@ -103,6 +104,22 @@ describe("render smoke tests", () => {
|
||||
assert.match(html, /Your thinking/, "ask select-mode also gets the learner's voice");
|
||||
});
|
||||
|
||||
it("multi-select ask renders checkbox rows and the select-all hint", () => {
|
||||
const html = renderDock({
|
||||
toolName: "ask_user_question",
|
||||
toolCallId: "m1",
|
||||
input: {
|
||||
question: "Which topics interest you?",
|
||||
multiSelect: true,
|
||||
options: [{ label: "Physics" }, { label: "Philosophy" }],
|
||||
} as never,
|
||||
});
|
||||
assert.match(html, /select all that apply/);
|
||||
assert.ok(html.includes('role="group"'), "checkbox group");
|
||||
assert.ok((html.match(/role="checkbox"/g) ?? []).length >= 3, "options AND the Other row are checkboxes");
|
||||
assert.ok(html.includes('data-testid="other-option"'), "Other is still an option row in multi-select");
|
||||
});
|
||||
|
||||
it("phase scales the thinking field: teaching invites depth, probing stays quick", () => {
|
||||
const teach = renderToStaticMarkup(
|
||||
<QuestionDock
|
||||
@@ -302,3 +319,60 @@ describe("teach-check reveal (W5 phase separation)", () => {
|
||||
});
|
||||
});
|
||||
|
||||
// ─── probe-done card (the malformed-assessment crash) ─────────────────────
|
||||
// The live bug: the model stringified `assessment` (a rejected input), and
|
||||
// the card's input-preview fallback trusted the shape — strands died. The
|
||||
// preview now reads only pending inputs; an errored part renders the quiet
|
||||
// retry note.
|
||||
describe("probe-done card", () => {
|
||||
const validAssessment = {
|
||||
strands: [
|
||||
{ strand: "modal logic basics", assessment: "Floor: solid intuition; ceiling: notation." },
|
||||
{ strand: "indexical 'actual'", assessment: "Genuine floor — prior exposure likely." },
|
||||
],
|
||||
summary: "Bracketed: teach the symbols on the intuition he has.",
|
||||
};
|
||||
|
||||
it("renders the strand-by-strand assessment from the seam ack", () => {
|
||||
const html = renderToStaticMarkup(
|
||||
<ProbeDoneCard
|
||||
part={{ state: "output-available", output: { ok: true, assessment: validAssessment } } as never}
|
||||
/>,
|
||||
);
|
||||
assert.ok(html.includes('data-testid="probe-done-card"'));
|
||||
assert.match(html, /modal logic basics/);
|
||||
assert.match(html, /indexical 'actual'|indexical 'actual'/);
|
||||
assert.match(html, /Bracketed/);
|
||||
});
|
||||
|
||||
it("previews the assessment from a PENDING (validated) input", () => {
|
||||
const html = renderToStaticMarkup(
|
||||
<ProbeDoneCard part={{ state: "input-available", input: { assessment: validAssessment } } as never} />,
|
||||
);
|
||||
assert.match(html, /modal logic basics/);
|
||||
});
|
||||
|
||||
it("a REJECTED assessment (the stringified live shape) renders the retry note, never the garbage", () => {
|
||||
// The exact live crash: assessment arrived as a string, zod rejected
|
||||
// the call, the model retried — this dead part must not explode.
|
||||
const html = renderToStaticMarkup(
|
||||
<ProbeDoneCard
|
||||
part={{
|
||||
state: "output-error",
|
||||
errorText: "Validation failed",
|
||||
input: { assessment: "strands: [{\"strand\": ...stringified garbage" },
|
||||
} as never}
|
||||
/>,
|
||||
);
|
||||
assert.match(html, /malformed/);
|
||||
assert.match(html, /retried/);
|
||||
assert.ok(!html.includes("strands:"), "the rejected input never renders");
|
||||
});
|
||||
|
||||
it("a mid-stream partial without strands renders the writing note, not a crash", () => {
|
||||
const html = renderToStaticMarkup(
|
||||
<ProbeDoneCard part={{ state: "input-streaming", input: { assessment: { summary: "…" } } } as never} />,
|
||||
);
|
||||
assert.match(html, /Writing the assessment/);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user