amosblomqvist
cf042b25e7
The hand-packed icns was pixel-clean (verified by unpacking and scanning every size), but macOS 26 composites legacy .icns icons into the Liquid Glass system at render time; stacked on Icon Composer's baked PNG-export lighting, that clips the rim highlights into the near-corner specks and abrupt highlight ends (owner report 2026-10-13). The fix is the real layered icon: mac.icon now points at the Icon Composer document (build/icon.icon, copied from ~/Documents/Affinity/lh-logo) and electron-builder compiles it via actool into Assets.car — macOS 26+ renders the true Liquid Glass design (dark/tinted variants included). actool's backwards-compat icns caps at 256px, so scripts/after-pack.cjs swaps in the existing full-res build/icon.icns before signing: pre-Tahoe macOS keeps today's quality, Tahoe gets the layered icon. Windows/Linux get the owner's flat design (rounded squircle with baked transparency): scripts/make-icons.mjs renders build/icon-flat.svg via resvg into build/icon.ico (16→256 PNG entries) + build/icon.png (512), and electron-builder.yml pins win.icon/linux.icon. desktop:dist injects DEVELOPER_DIR (actool needs Xcode; the machine selects CommandLineTools by default, CI's setup-xcode takes precedence via the :- default). The release workflow's mac job selects Xcode 26+ explicitly. Verified locally: mac --dir build (Assets.car + checksummed full-res fallback + CFBundleIconName/IconFile) and the win-unpacked exe carries our ico bytes; NSIS/AppImage assembly is CI's (cross-build tooling can't run on arm64 macOS). Runbook updated. 1610/1610.
28 lines
1.4 KiB
JavaScript
28 lines
1.4 KiB
JavaScript
// electron-builder afterPack hook — mac only.
|
|
//
|
|
// WHY (owner ruling 2026-10-13): mac.icon is the Icon Composer document
|
|
// (build/icon.icon); actool compiles it into Assets.car (the macOS 26
|
|
// Liquid Glass render) PLUS a backwards-compat icns — but actool's
|
|
// fallback icns caps at 256px (known actool behavior), which looks soft
|
|
// at Finder/Launchpad sizes on pre-Tahoe macOS. This hook swaps in the
|
|
// hand-packed full-res build/icon.icns (all 10 entries, 16→1024, packed
|
|
// via iconutil from the design's PNG exports) AFTER packaging and BEFORE
|
|
// signing, so:
|
|
//
|
|
// macOS 26+ → Assets.car (CFBundleIconName) — true layered glass icon;
|
|
// older mac → icon.icns (CFBundleIconFile) — today's full-res flatten.
|
|
//
|
|
// Windows/Linux builds return immediately (their icons are static files:
|
|
// build/icon.ico / build/icon.png).
|
|
const fs = require("node:fs");
|
|
const path = require("node:path");
|
|
|
|
module.exports = async function afterPack(context) {
|
|
if (context.electronPlatformName !== "darwin") return;
|
|
const appBundle = path.join(context.appOutDir, `${context.packager.appInfo.productFilename}.app`);
|
|
const target = path.join(appBundle, "Contents", "Resources", "icon.icns");
|
|
const source = path.join(context.packager.info.projectDir, "build", "icon.icns");
|
|
fs.copyFileSync(source, target);
|
|
console.log(`[after-pack] pre-Tahoe fallback icns (full-res) → ${target}`);
|
|
};
|