amosblomqvist
cb4fe25c89
- src/core/settings.ts: versioned DELTA record schema + sanitizer (unknown keys preserved)
— general/chat/agent{models,tools,prompts}/appearance/graph sections
- src/core/settings-resolution.ts: pure resolveSettings (factory defaults → user delta),
extraction/graph-context channel predicates
- src/store/settings.ts + prompt-overrides.ts: SettingsStore/PromptOverrideStore adapters
wired through stores.ts (effectiveSettings() fresh per call); lazy migration of
default-settings.json into record.chat
- app/api/settings/** routes (record, section bodies, prompt overrides per segment)
- chat-handler: graph gates at trigger call-sites + toolToggles injection seam
- config.ts: SETTINGS_FILE + PROMPTS_OVERRIDE_DIR paths
587/587 tests; typecheck/lint/build clean
66 lines
2.4 KiB
TypeScript
66 lines
2.4 KiB
TypeScript
/**
|
|
* Tests for the shared settings-body parser, chat-section flavor
|
|
* (default-settings wave, 2026-09-18; record-backed 2026-09-19): the seam
|
|
* behind BOTH chat-settings routes — per-chat and the defaults alias.
|
|
*
|
|
* The record store, the legacy-file migration, and the record-backed
|
|
* default-settings facade are covered in tests/settings-store.test.ts
|
|
* (one fs owner per file — the test runner executes files in parallel).
|
|
*/
|
|
|
|
import assert from "node:assert/strict";
|
|
import { describe, it } from "node:test";
|
|
import { GRAPH_CONTEXT_TOKENS_MAX } from "../src/core";
|
|
import { parseSettingsBody } from "../src/server/settings-body.ts";
|
|
|
|
describe("parseSettingsBody (shared by both settings routes)", () => {
|
|
it("an empty object parses to {} — the clear-overrides write", () => {
|
|
const r = parseSettingsBody({});
|
|
assert.ok(r.ok);
|
|
assert.deepEqual(r.ok ? r.settings : null, {});
|
|
});
|
|
|
|
it("a full valid body parses field-for-field", () => {
|
|
const r = parseSettingsBody({
|
|
model: { provider: "openrouter", id: "z-ai/glm-5.3-flash" },
|
|
thinkingLevel: "high",
|
|
graphContextTokens: 256,
|
|
});
|
|
assert.ok(r.ok);
|
|
assert.deepEqual(r.settings, {
|
|
model: { provider: "openrouter", id: "z-ai/glm-5.3-flash" },
|
|
thinkingLevel: "high",
|
|
graphContextTokens: 256,
|
|
});
|
|
});
|
|
|
|
it("partial bodies keep only the present overrides (replace-whole)", () => {
|
|
const r = parseSettingsBody({ thinkingLevel: "low" });
|
|
assert.ok(r.ok);
|
|
assert.deepEqual(r.settings, { thinkingLevel: "low" });
|
|
});
|
|
|
|
it("rejects non-object bodies", () => {
|
|
for (const body of ["junk", 42, [{}]]) {
|
|
const r = parseSettingsBody(body);
|
|
assert.equal(r.ok, false, JSON.stringify(body));
|
|
if (!r.ok) assert.match(r.error, /Invalid JSON body/);
|
|
}
|
|
});
|
|
|
|
it("rejects malformed model and non-string thinkingLevel", () => {
|
|
assert.equal(parseSettingsBody({ model: "nope" }).ok, false);
|
|
assert.equal(parseSettingsBody({ model: { provider: 1, id: "x" } }).ok, false);
|
|
assert.equal(parseSettingsBody({ thinkingLevel: 7 }).ok, false);
|
|
});
|
|
|
|
it("rejects out-of-range or non-integer graphContextTokens — never clamps", () => {
|
|
for (const bad of [-1, GRAPH_CONTEXT_TOKENS_MAX + 1, 64.5, "256"]) {
|
|
const r = parseSettingsBody({ graphContextTokens: bad });
|
|
assert.equal(r.ok, false, String(bad));
|
|
}
|
|
const ok = parseSettingsBody({ graphContextTokens: GRAPH_CONTEXT_TOKENS_MAX });
|
|
assert.equal(ok.ok, true);
|
|
});
|
|
});
|