Diagnosis (2026-09-11 user testing, minimal-effort GLM): sessions stuck on 'plan' forever. Two causes: (1) the three-phase view read the stored tree's currentNodeId, which nothing ever writes post author-once (2026-09-03) — a structural dead seam; (2) the teacher stochastically left quiz.nodeId untagged, and done-by-quiz-result semantics would have falsely completed nodes anyway. The redesign (docs/probe-teach-split.md) abolishes derived occupancy in favor of explicit events: - Two agents over one transcript: createProberAgent (quiz without a nodeId field, ask, probe_done) and createTeacherAgent (full toolset, plan_init onward). The chat-handler construction branch keys on a probe_done part in the transcript. MODELS.prober added. - probe_done: server-side seam tool — carries the learner assessment (strands + free-form edge read), refuses while a question is open or the probe is already concluded, and queues a handoff steer through the generalized wake pipeline (steers now dedupe by id, not jobId; job finalization only for job steers). The teacher auto-wakes and authors the plan; the learner sees the assessment via the probe-done card. - phases: probe ends at a concluded probe_done, plan ends at a successful plan_init — strictly sequential, no skipping, no legacy compatibility (data wiped at the pivot per doctrine). - Plan map = position, not completion: derivePlanStatuses reads only tagged quiz CALLS (state/outcome feed nothing); current = latest tagged node with consecutive duplicates collapsed, visited = earlier distinct stays (a revisit stays in both — current wins at render). PlanTree is structure-only; currentNodeId/doneNodeIds and the dead mutation helpers are gone. No fallback current. - Prompts split per agent (prompts/prober/, prompts/teacher/ over the trimmed shared base); graph-context injection removed entirely (shelved, docs/probe-teach-split.md §5); knowledge-graph context no longer reaches either agent. - Plan blocks are full-only snapshots at plan_init (neighborhood machinery retired; the persistent DAG window is the future UI wave); usage capture unchanged. Gates: tsc clean, 294/294 tests (phases/plan-tree/plan-blocks/question- tools rewritten to the new semantics; probe-done + handoff-wake tests added), lint, build. Live GLM smoke PASS: prober concluded with an honest assessment, teacher auto-woke, authored a 10-node plan with the block attached, then tagged checks on slope-instinct → secant derived current/ visited exactly as designed; grading honest both ways (driver off-by-one proved a wrong answer grades false).
118 lines
5.2 KiB
TypeScript
118 lines
5.2 KiB
TypeScript
/**
|
|
* Plan-tree contracts — the session-scoped dependency tree
|
|
*
|
|
* Part of the domain-split contracts (src/core/contracts/): each domain file
|
|
* is owned outright by its stream — cross-domain schema changes go through
|
|
* master. Pure types + protocol docs + tiny pure helpers; type-only imports
|
|
* of "ai" (safe everywhere: server, client, tests). See docs/vision.md.
|
|
*/
|
|
// ─── Plan tree (vision §2 "formal plan tree") ────────────────────────────────
|
|
// A session-scoped dependency tree authored by the teacher via plan tools.
|
|
// One substrate with the global graph: tree nodes fold into graph nodes.
|
|
|
|
export interface PlanNode {
|
|
/** Opaque, agent-chosen slug, stable across edits: "chain-rule-intuition". */
|
|
id: string;
|
|
/** Short label for the tree panel. */
|
|
title: string;
|
|
/** 1-2 sentences: what this node covers. */
|
|
summary?: string;
|
|
}
|
|
|
|
export interface PlanEdge {
|
|
/** Prerequisite node id. */
|
|
from: string;
|
|
/** Node that depends on `from`. */
|
|
to: string;
|
|
}
|
|
|
|
export interface PlanTree {
|
|
nodes: PlanNode[];
|
|
edges: PlanEdge[];
|
|
/** Increments on every mutation — lets the UI animate/react to changes. */
|
|
version: number;
|
|
}
|
|
|
|
// NOTE (2026-09-11 pivot, docs/probe-teach-split.md): the tree once carried
|
|
// `currentNodeId` / `doneNodeIds` — progress fields. They are GONE by
|
|
// design: the tree carries structure ONLY; position and visited-ness derive
|
|
// from the transcript at render time (derivePlanStatuses below). There is no
|
|
// done ledger of any kind. No backwards compatibility for old records.
|
|
|
|
/** Derived, never stored: status of a node for the panel (vision §2). */
|
|
export type PlanNodeStatus = "current" | "visited" | "upcoming";
|
|
|
|
// ─── derived statuses: position from CALLS, never from results ─────────────
|
|
//
|
|
// (2026-09-11 pivot — docs/probe-teach-split.md §3.) The teacher AUTHORS the
|
|
// map (plan_init, mermaid — re-callable rewrite) and never tracks progress.
|
|
// The quiz `nodeId` means "this question is ABOUT this node" — a position
|
|
// signal, never a completion signal. Derivation reads CALLS only:
|
|
// current — the node of the most RECENT tagged quiz call (any state)
|
|
// visited — every node referenced by an EARLIER tagged call
|
|
// Consequences: a node spans multiple turns/checks naturally (several
|
|
// questions may tag the same node — the map holds still); moving to a new
|
|
// node is the teacher's judgment the previous one is finished, regardless of
|
|
// check outcomes (a failed check then a move-on is still visited); results
|
|
// feed nothing; there is NO fallback current (before the first tagged check
|
|
// nothing is current). Untagged checks are legal ad-hoc checks — they move
|
|
// nothing. NodeIds missing from the current tree are ignored (a rewrite
|
|
// may have dropped the node).
|
|
|
|
/** Minimal structural message slice — anything with typed parts (mirrors
|
|
* phases.ts: pure, no runtime deps, safe on server, client, and in tests). */
|
|
interface PartsCarrier {
|
|
parts: Array<{ type: string; state?: string; input?: unknown; output?: unknown }>;
|
|
}
|
|
|
|
export interface DerivedPlanStatuses {
|
|
/** The node the most recent tagged quiz call is about; null before any. */
|
|
current: string | null;
|
|
/** Nodes referenced by earlier tagged calls — been there, monotonic. */
|
|
visited: ReadonlySet<string>;
|
|
}
|
|
|
|
/** Statuses of a node: the derived view the plan panel should render. */
|
|
export function derivedNodeStatus(statuses: DerivedPlanStatuses, nodeId: string): PlanNodeStatus {
|
|
if (statuses.current === nodeId) return "current";
|
|
if (statuses.visited.has(nodeId)) return "visited";
|
|
return "upcoming";
|
|
}
|
|
|
|
export function derivePlanStatuses(tree: PlanTree, messages: readonly PartsCarrier[]): DerivedPlanStatuses {
|
|
const ids = new Set(tree.nodes.map((n) => n.id));
|
|
const runs: string[] = []; // distinct tagged nodes in call order, CONSECUTIVE
|
|
// duplicates collapsed (several checks on one node = one stay on it)
|
|
for (const m of messages) {
|
|
for (const part of m.parts) {
|
|
if (part.type !== "tool-quiz") continue;
|
|
const nodeId = (part.input as { nodeId?: unknown } | undefined)?.nodeId;
|
|
if (typeof nodeId !== "string" || !ids.has(nodeId)) continue; // untagged/unknown — moves nothing
|
|
if (runs.at(-1) !== nodeId) runs.push(nodeId);
|
|
}
|
|
}
|
|
const current = runs.at(-1) ?? null;
|
|
// Visited = been there in an EARLIER stay: everything before the current
|
|
// run. A revisit (a→b→a) puts a in visited AND current — current wins at
|
|
// render (derivedNodeStatus), visited records it has been left before.
|
|
const visited = new Set(runs.slice(0, -1));
|
|
return { current, visited };
|
|
}
|
|
|
|
/**
|
|
* The plan tool result (author-once protocol, 2026-09-03): ONE server-side
|
|
* tool, plan_init (tools/plan.ts) — a mermaid `graph TD` block canonicalized
|
|
* into the structured tree, called once at the probe→teach seam and
|
|
* re-callable to rewrite. The former mutation/tracking tools are gone:
|
|
* statuses derive from check outcomes (derivePlanStatuses above), so the
|
|
* tree carries structure, never progress. The tree panel still derives its
|
|
* display from the LATEST plan tool output in the transcript — plus the
|
|
* derived statuses — with no separate state channel.
|
|
*/
|
|
export interface PlanToolResult {
|
|
ok: boolean;
|
|
error?: string;
|
|
tree: PlanTree;
|
|
}
|
|
|