learnharness/tests/settings-body.test.ts

/**
 * Tests for the section parsers (settings-storage wave, 2026-09-19):
 * src/server/settings-body.ts — general/agent/appearance/graph strictness.
 * Same discipline as parseSettingsBody (its tests live in
 * default-settings.test.ts): every known field is strict (bad type/shape
 * → 400-style error, never a silent clamp), unknown keys drop, absent
 * fields mean absent overrides. Pure — no fs.
 */

import assert from "node:assert/strict";
import { describe, it } from "node:test";
import {
	parseAgentSettingsBody,
	parseModelsSettingsBody,
	parseAppearanceSettingsBody,
	parseGeneralSettingsBody,
	parseGraphSettingsBody,
	SETTINGS_SECTIONS,
} from "../src/server/settings-body.ts";

describe("parseGeneralSettingsBody", () => {
	it("parses {} and {autoUpdate} replace-whole", () => {
		const empty = parseGeneralSettingsBody({});
		assert.ok(empty.ok);
		assert.deepEqual(empty.settings, {});
		const on = parseGeneralSettingsBody({ autoUpdate: true });
		assert.ok(on.ok);
		assert.deepEqual(on.settings, { autoUpdate: true });
	});

	it("rejects non-objects and non-boolean autoUpdate", () => {
		assert.equal(parseGeneralSettingsBody("x").ok, false);
		assert.equal(parseGeneralSettingsBody({ autoUpdate: "yes" }).ok, false);
	});
});

describe("parseAgentSettingsBody", () => {
	it("models: valid roles with model pair and/or thinkingLevel; unknown role is a 400 with the list", () => {
		const r = parseAgentSettingsBody({
			models: {
				researcher: { model: { provider: "openrouter", id: "qwen/qwen3.8-flash" } },
				auditor: { thinkingLevel: "high" },
			},
		});
		assert.ok(r.ok);
		assert.deepEqual(r.settings.models, {
			researcher: { model: { provider: "openrouter", id: "qwen/qwen3.8-flash" } },
			auditor: { thinkingLevel: "high" },
		});
		const bad = parseAgentSettingsBody({ models: { teacher: {} } });
		assert.equal(bad.ok, false);
		if (!bad.ok) assert.match(bad.error, /unknown role "teacher" \(supported: researcher, demoBuilder, visualMaker, extractor, auditor, partitioner, problemGenerator, grader\)/);
		const malformed = parseAgentSettingsBody({ models: { researcher: { model: { provider: 1, id: "x" } } } });
		assert.equal(malformed.ok, false);
	});

	it("tools and prompts: boolean maps; non-boolean values are 400s", () => {
		const r = parseAgentSettingsBody({ tools: { research: false }, prompts: { "system-prompt.md": true } });
		assert.ok(r.ok);
		assert.deepEqual(r.settings.tools, { research: false });
		assert.deepEqual(r.settings.prompts, { "system-prompt.md": true });
		assert.equal(parseAgentSettingsBody({ tools: { quiz: "no" } }).ok, false);
		assert.equal(parseAgentSettingsBody({ prompts: { "x.md": 1 } }).ok, false);
		// switch validity (segment membership, file presence) is the ROUTE's
		// cross-validation — the parser only sees shapes.
	});

	it("search: engine pin is tavily|brave; anything else is a 400 (search wave, 2026-09-20)", () => {
		const ok = parseAgentSettingsBody({ search: { engine: "tavily" } });
		assert.ok(ok.ok);
		assert.deepEqual(ok.settings.search, { engine: "tavily" });
		const clear = parseAgentSettingsBody({ search: {} });
		assert.ok(clear.ok);
		assert.equal(clear.settings.search, undefined, "absent engine = back to auto-detect");
		assert.equal(parseAgentSettingsBody({ search: { engine: "google" } }).ok, false);
		assert.equal(parseAgentSettingsBody({ search: "tavily" }).ok, false, "search must be an object");
		assert.equal(parseAgentSettingsBody({ search: { engine: 1 } }).ok, false);
	});

	it("graphTools: strict object subsection, enabled boolean when present — wave 7, 2026-09-23", () => {
		const off = parseAgentSettingsBody({ graphTools: { enabled: false } });
		assert.ok(off.ok);
		assert.deepEqual(off.settings.graphTools, { enabled: false });
		const bare = parseAgentSettingsBody({ graphTools: {} });
		assert.ok(bare.ok);
		assert.deepEqual(bare.settings.graphTools, {}, "explicit subsection with no key = the default ON");
		assert.equal(parseAgentSettingsBody({ graphTools: "off" }).ok, false, "graphTools must be an object");
		assert.equal(parseAgentSettingsBody({ graphTools: { enabled: "yes" } }).ok, false, "enabled must be a boolean");
		assert.equal(parseAgentSettingsBody({ graphTools: null }).ok, false);
	});

	it("an empty {} agent section parses to {} (replace-whole clear)", () => {
		const r = parseAgentSettingsBody({});
		assert.ok(r.ok);
		assert.deepEqual(r.settings, {});
	});
});

describe("parseAppearanceSettingsBody", () => {
	it("parses every field; hex-or-null colors; clamps happen at sanitize, rejects here", () => {
		const r = parseAppearanceSettingsBody({
			mode: "light",
			background: "#ffffff",
			fontFamily: "Some Font",
			proseFontSize: 20,
			sessionNameSerif: false,
			mdRendering: { headingWeight: 700, boldColor: "#ff8800", italicColor: null },
		});
		assert.ok(r.ok);
		assert.deepEqual(r.settings, {
			mode: "light",
			background: "#ffffff",
			fontFamily: "Some Font",
			proseFontSize: 20,
			sessionNameSerif: false,
			mdRendering: { headingWeight: 700, boldColor: "#ff8800", italicColor: null },
		});
	});

	it("rejects bad enums, ranges, and colors — with specific messages, never clamps", () => {
		const cases: unknown[] = [
			{ mode: "sepia" },
			{ background: "blue" },
			{ background: 42 },
			{ fontFamily: "" },
			{ fontFamily: 12 },
			{ proseFontSize: 30 },
			{ proseFontSize: 64.5 },
			{ sessionNameSerif: 1 },
			{ mdRendering: { headingWeight: 1000 } },
			{ mdRendering: { boldColor: "red" } },
		];
		for (const body of cases) {
			assert.equal(parseAppearanceSettingsBody(body).ok, false, JSON.stringify(body));
		}
		// boundary values that MUST pass: 12 and 24, 100 and 900, #fff
		assert.ok(parseAppearanceSettingsBody({ proseFontSize: 12 }));
		assert.ok(parseAppearanceSettingsBody({ proseFontSize: 24 }));
		assert.ok(parseAppearanceSettingsBody({ mdRendering: { headingWeight: 100 } }));
		assert.ok(parseAppearanceSettingsBody({ mdRendering: { headingWeight: 900 } }));
		assert.ok(parseAppearanceSettingsBody({ background: "#abc" }));
		// null = "the mode's default" — explicit, valid
		assert.ok(parseAppearanceSettingsBody({ background: null, fontFamily: null }));
	});

	it("rejects non-object bodies and non-object mdRendering", () => {
		assert.equal(parseAppearanceSettingsBody([1]).ok, false);
		assert.equal(parseAppearanceSettingsBody({ mdRendering: "big" }).ok, false);
	});
});

describe("parseGraphSettingsBody", () => {
	it("parses the collapsed section replace-whole (wave 7: the master switch ONLY)", () => {
		const r = parseGraphSettingsBody({ enabled: false });
		assert.ok(r.ok);
		assert.deepEqual(r.settings, { enabled: false });
		assert.equal(parseGraphSettingsBody({}).ok, true);
	});

	it("rejects non-boolean switches and unknown bodies", () => {
		assert.equal(parseGraphSettingsBody({ enabled: "off" }).ok, false);
		assert.equal(parseGraphSettingsBody("nope").ok, false);
	});

	it("extractionChunkTokens: whole tokens ≥ the 500 floor (extraction-UX redesign, 2026-09-24)", () => {
		const ok = parseGraphSettingsBody({ enabled: true, extractionChunkTokens: 2048 });
		assert.ok(ok.ok);
		assert.deepEqual(ok.settings, { enabled: true, extractionChunkTokens: 2048 });
		// absent = unset — replace-whole keeps the factory default at resolution
		const absent = parseGraphSettingsBody({ enabled: true });
		assert.ok(absent.ok);
		assert.deepEqual(absent.settings, { enabled: true });
		// fractions floor to whole tokens
		const fraction = parseGraphSettingsBody({ extractionChunkTokens: 1024.9 });
		assert.ok(fraction.ok);
		assert.equal(fraction.settings.extractionChunkTokens, 1024);
		// below the cost floor: 400 with the floor named (penny-batches)
		const tiny = parseGraphSettingsBody({ extractionChunkTokens: 100 });
		assert.equal(tiny.ok, false, "below-floor rejected");
		assert.match(tiny.ok === false ? tiny.error : "", /at least 500/);
		// junk shapes: 400
		assert.equal(parseGraphSettingsBody({ extractionChunkTokens: "4096" }).ok, false);
		assert.equal(parseGraphSettingsBody({ extractionChunkTokens: NaN }).ok, false);
		assert.equal(parseGraphSettingsBody({ extractionChunkTokens: null }).ok, false);
	});

	it("the dead wave-6 rungs in a body are ignored — the section collapses on write", () => {
		// Old clients may still send {embedding: true, embeddingModel: …};
		// the parser reads ONLY the master switch — the dead keys are not
		// an error, they are just not part of the section anymore.
		const r = parseGraphSettingsBody({ enabled: false, clustering: true, labeling: true });
		assert.ok(r.ok);
		assert.deepEqual(r.settings, { enabled: false });
	});
});

describe("SETTINGS_SECTIONS (the route's section map)", () => {
	it("maps exactly the six record sections", () => {
		assert.deepEqual(Object.keys(SETTINGS_SECTIONS), ["general", "chat", "agent", "appearance", "graph", "models"]);
	});
});

describe("parseModelsSettingsBody (model slots wave, 2026-09-20)", () => {
	it("parses the three slot tiers — model required, level rides (BYOK, owner 2026-09-22)", () => {
		const r = parseModelsSettingsBody({
			strong: { model: { provider: "openrouter", id: "z-ai/glm-5.3-flash" } },
			cheap: { model: { provider: "zai", id: "glm-5.3-flash" }, thinkingLevel: "high" },
			vision: { model: { provider: "zai", id: "glm-5.3-flash" }, thinkingLevel: "low" },
		});
		assert.ok(r.ok);
		assert.deepEqual(r.settings, {
			strong: { model: { provider: "openrouter", id: "z-ai/glm-5.3-flash" } },
			cheap: { model: { provider: "zai", id: "glm-5.3-flash" }, thinkingLevel: "high" },
			vision: { model: { provider: "zai", id: "glm-5.3-flash" }, thinkingLevel: "low" },
		});
		// a thinkingLevel WITHOUT a model can never run (no factory floor)
		const levelOnly = parseModelsSettingsBody({ cheap: { thinkingLevel: "high" } });
		assert.equal(levelOnly.ok, false);
		if (!levelOnly.ok) {
			assert.match(levelOnly.error, /slot "cheap" must set a model/);
		}
	});

	it("{} is the legal clear-slots write", () => {
		const r = parseModelsSettingsBody({});
		assert.ok(r.ok);
		assert.deepEqual(r.settings, {});
	});

	it("unknown slots are 400s with the supported list", () => {
		const bad = parseModelsSettingsBody({ mega: { thinkingLevel: "high" } });
		assert.equal(bad.ok, false);
		if (!bad.ok) assert.match(bad.error, /unknown slot "mega" \(supported: strong, cheap, vision\)/);
	});

	it("a present-but-empty slot object is rejected (absent slot = unset)", () => {
		const bad = parseModelsSettingsBody({ strong: {} });
		assert.equal(bad.ok, false);
		if (!bad.ok) assert.match(bad.error, /slot "strong" must set a model/);
	});

	it("malformed slot shapes are 400s", () => {
		assert.equal(parseModelsSettingsBody({ cheap: { model: { provider: "x" } } }).ok, false);
		assert.equal(parseModelsSettingsBody({ vision: { thinkingLevel: 7 } }).ok, false);
		assert.equal(parseModelsSettingsBody("nope").ok, false);
	});
});