amosblomqvist
35d8bc1a0c
Owner ruling (2026-09-30, live-testing loop — supersedes 02a58db's exemption): implication nodes ARE depth-anchored after all. Their anchor is the average of the HIGHEST premise row and the conclusion's row — depth(imp) = (max(premise depths) + depth(conclusion)) / 2 — so the junction always sits strictly above every premise and strictly below the conclusion (a conclusion is >= highest premise + 1 in the logical graph). Uniform across modes: a half-row in vertical, a ring midway in radial (owner confirmed both). Implementation: - layout.ts: new ImpLink type; SimOptions/incrementalLayout gain impLinks (the derived chain linkage). The rank map is now computed once alongside the orphan mask: proposition ranks via Tarjan over the logical edges, then each supplied link adds its midpoint entry. An imp node WITH an anchor is structured (leaves the orphan mask — gravity projections treat it like any ranked node); WITHOUT supplied links, arg_ ids keep the legacy 02a58db exemption (honest fallback for callers that predate the field). The depth force reuses the precomputed map — one pass, shared. - deriveView (core/graph.ts) emits impLinks (one per multi-premise live chain — single-premise chains mint no imp node); GraphSnapshot carries them; graph-view maps them into CanvasData; settleGraphLayout and replay-layout forward them (replay activates a junction's link exactly when its chain is delivered). Tests (+3, 1 rewritten): the 02a58db exemption pin became the MIDPOINT pin (premises row 0, conclusion row -500, junction pinned to -250); mixed-depth pin (premises at 0 and 1, conclusion 2, junction at the 1.5 half-row — highest premise, not average-of-premises); legacy fallback pin (no impLinks = never depth-anchored); deriveView impLinks emission pin (multi-premise only). The horizontal-pole and ORPHAN RULE pins from 5554c3a survive unchanged — proposition orphans are untouched.
55 lines
2.7 KiB
TypeScript
55 lines
2.7 KiB
TypeScript
import type { GraphChain, GraphNode, Position } from "./contracts.ts";
|
|
import { incrementalLayout } from "./layout.ts";
|
|
import { attachImpToCommunities, birthSessionPartition } from "./session-clusters.ts";
|
|
import { deriveView, getGraph } from "./graph.ts";
|
|
|
|
/**
|
|
* The merge-time settle: recompute the resting layout from the CURRENT
|
|
* graph + the positions ledger, and replace the ledger. Called by the
|
|
* extraction pipeline after every merge (the sole writer) and by the
|
|
* positions-commit endpoint when the graph grew under a live-physics
|
|
* commit (client positions become the anchor set). Synchronous — it must
|
|
* finish before the next /api/graph fetch reflects the change.
|
|
*
|
|
* CHAINS-PRIMARY (owner, 2026-09-30): the settle lays out the DERIVED
|
|
* view — propositions AND the derived implication nodes (one per chain,
|
|
* arg_ ids) over the derived untyped arrows — so positions exist for
|
|
* every node the canvas renders. Implication nodes participate in the
|
|
* physics as regular nodes (rendering specialization comes later).
|
|
*
|
|
* SPLIT FROM layout.ts deliberately (2026-09-13): layout.ts is in the
|
|
* browser barrel, and the settle needs the cluster partition for the
|
|
* cluster centroid pull — this module must not ship in the client bundle.
|
|
* Server code imports it DIRECTLY; it is never re-exported through
|
|
* src/core/index.ts.
|
|
*/
|
|
export function settleGraphLayout(graphStore: {
|
|
readNodes(): GraphNode[];
|
|
readChains(): GraphChain[];
|
|
readPositions(): Record<string, Position>;
|
|
writePositions(positions: Record<string, Position>): void;
|
|
}): void {
|
|
const graph = getGraph(graphStore);
|
|
if (graph.nodes.length === 0) return;
|
|
const view = deriveView(graph);
|
|
const previous = new Map(Object.entries(graphStore.readPositions()));
|
|
// The cluster partition for the centroid pull: the SAME birth-session
|
|
// partition the snapshot renders (derived from provenance on read —
|
|
// core/session-clusters.ts, wave 7) — one cluster concept everywhere.
|
|
// PROPOSITIONS ONLY (owner, 2026-09-30): implication nodes never
|
|
// partition; the stored world clusters, its image follows.
|
|
const communities = birthSessionPartition(graph.nodes);
|
|
// The SAME imp-node assignment the snapshot renders (majority among
|
|
// premises' births — core/session-clusters.ts): the resting ledger and
|
|
// the live sim must agree on where bundles belong, or the first live
|
|
// tick would fight the settle. Unfiltered here (settle pulls every
|
|
// community, hulls are a canvas-only concern).
|
|
attachImpToCommunities(communities, graph.nodes, graph.chains);
|
|
const next = incrementalLayout(view.nodes, view.edges, previous, {
|
|
clusters: communities,
|
|
logicalEdges: view.logicalEdges,
|
|
impLinks: view.impLinks,
|
|
});
|
|
graphStore.writePositions(Object.fromEntries(next));
|
|
}
|