amosblomqvist
571cc94053
Root cause: doSteerOrSend branched on turnInFlight, but the local dedup (chat.tsx ~370) clears that flag the moment the own stream takes over — during our own turn busy was true and turnInFlight false, so Enter fell to the plain-send path whose busy guard returned silently. Branch on busy: own stream AND foreign/wake turns both have a live agent registered by the time the send's POST resolved, so the steer lands (a raced settle 409s and falls back to the plain send). The button now follows the text: busy + typed text = Send (click steers — steering must be clickable, not Enter-only); busy + empty = Stop. ESC keeps its confirm-popup abort in every state, so stop is never unreachable.
83 lines
3.4 KiB
TypeScript
83 lines
3.4 KiB
TypeScript
/**
|
||
* Composer render tests — the chat input row (content only; the persistent
|
||
* rounded shell lives in the chat view's overlay so it can morph into the
|
||
* question dock without remounting).
|
||
*
|
||
* Same tsx classic-JSX shim as render-cards.test.tsx.
|
||
*/
|
||
import React from "react";
|
||
(globalThis as Record<string, unknown>).React = React;
|
||
|
||
import assert from "node:assert/strict";
|
||
import { describe, it } from "node:test";
|
||
import { renderToStaticMarkup } from "react-dom/server";
|
||
import { Composer, enterAction } from "../components/composer.tsx";
|
||
|
||
function render(opts: { busy?: boolean; canSend?: boolean; placeholder?: string } = {}) {
|
||
return renderToStaticMarkup(
|
||
<Composer
|
||
busy={opts.busy ?? false}
|
||
value=""
|
||
onChange={() => {}}
|
||
onSend={() => {}}
|
||
onStop={() => {}}
|
||
canSend={opts.canSend ?? true}
|
||
{...(opts.placeholder ? { placeholder: opts.placeholder } : {})}
|
||
/>,
|
||
);
|
||
}
|
||
|
||
describe("Composer", () => {
|
||
it("chat placeholder + send button", () => {
|
||
const html = render();
|
||
assert.match(html, /Ask, answer, or steer the lesson/, "the default — active sessions");
|
||
assert.ok(html.includes('aria-label="Send"'), "send button present");
|
||
});
|
||
|
||
it("placeholder is overridable — the new-session page asks the graph view's question", () => {
|
||
const html = render({ placeholder: "What do you want to learn?" });
|
||
assert.match(html, /What do you want to learn\?/);
|
||
assert.ok(!html.includes("Ask, answer"), "the session placeholder must not ride along");
|
||
});
|
||
|
||
it("busy with text: the button STAYS Send (click = steer); busy and empty: it becomes Stop", () => {
|
||
const steering = render({ busy: true, canSend: true });
|
||
assert.ok(steering.includes('aria-label="Send"'), "the steer affordance is clickable mid-turn");
|
||
assert.ok(!steering.includes('aria-label="Stop"'), "no morph while there is text to steer with");
|
||
const idleStop = render({ busy: true, canSend: false });
|
||
assert.ok(idleStop.includes('aria-label="Stop"'), "empty composer: stop replaces send while streaming");
|
||
});
|
||
|
||
it("send button radius is 10px = 25% of the 40px button (concentric with the shell)", () => {
|
||
const html = render();
|
||
assert.ok(html.includes("rounded-[10px]"), "send radius = shell radius − row padding");
|
||
assert.ok(html.includes("size-10"), "40px send button (10px = 25%)");
|
||
});
|
||
|
||
it("disabled when nothing to send", () => {
|
||
const html = render({ canSend: false });
|
||
assert.ok(/aria-label="Send"[^>]*disabled|disabled[^>]*aria-label="Send"/.test(html), "send disabled");
|
||
});
|
||
});
|
||
|
||
// The Enter decision (composer steering, 2026-10-03): while a turn runs,
|
||
// typed text makes Enter a STEER; Enter with an empty composer stays the
|
||
// stop shortcut. (The plan-verdict accept branch died 2026-09-26 with the
|
||
// verdict itself — the post-plan reply is a natural text message.) Pure
|
||
// function so the static-render harness can pin it (key events can't be
|
||
// simulated in renderToStaticMarkup).
|
||
describe("enterAction", () => {
|
||
it("busy stream with text: Enter steers (the queued send)", () => {
|
||
assert.equal(enterAction({ busy: true, canSend: true }), "send");
|
||
});
|
||
|
||
it("busy stream, empty composer: Enter stops", () => {
|
||
assert.equal(enterAction({ busy: true, canSend: false }), "stop");
|
||
});
|
||
|
||
it("idle: send when there is text, nothing when there is not", () => {
|
||
assert.equal(enterAction({ busy: false, canSend: true }), "send");
|
||
assert.equal(enterAction({ busy: false, canSend: false }), "none");
|
||
});
|
||
});
|