ui: simplify import feedback and shorten waiting status

This commit is contained in:
amosblomqvist
2026-10-23 06:14:33 +03:00
parent a67366005a
commit c36c1c6b4d
6 changed files with 189 additions and 76 deletions
+2 -2
View File
@@ -64,7 +64,7 @@
*/
import { useCallback, useDeferredValue, useEffect, useLayoutEffect, useMemo, useRef, useState } from "react";
import { NotesImportResults, useNotesImport } from "@/components/notes-import.tsx";
import { NotesImportErrors, useNotesImport } from "@/components/notes-import.tsx";
import Link from "next/link";
import { FileTextIcon, ListTreeIcon, Loader2Icon, SearchIcon, SettingsIcon, UploadIcon, WaypointsIcon } from "lucide-react";
import { incrementalLayout, propositionSessionHref, type GraphCostSummary, type GraphNode, type GraphSnapshot } from "@/src/core";
@@ -1605,7 +1605,7 @@ export function GraphView({
/>
</div>
<NotesImportResults {...notesImport} />
<NotesImportErrors errors={notesImport.errors} />
{/* Top-right tail (owner, 2026-09-20): the pipeline cost number —
just a number, hover-highlighted, dropdown breakdown — then
the running-pipeline pills under it. Lives BELOW the actions
+2 -2
View File
@@ -22,7 +22,7 @@ import { useCallback, useEffect, useRef, useState } from "react";
import { ListTreeIcon, UploadIcon } from "lucide-react";
import { ChainTableOverlay } from "@/components/chain-table.tsx";
import { GraphCostControl } from "@/components/graph-view.tsx";
import { NotesImportResults, useNotesImport } from "@/components/notes-import.tsx";
import { NotesImportErrors, useNotesImport } from "@/components/notes-import.tsx";
import { Hint } from "@/components/ui/hint";
import type { ChatSummary, GraphCostSummary, GraphSnapshot } from "@/src/core";
@@ -194,7 +194,7 @@ export function MinimalHome({
</Hint>
</div>
</div>
<NotesImportResults {...notesImport} />
<NotesImportErrors errors={notesImport.errors} />
{costs && costs.runs.length > 0 && <GraphCostControl costs={costs} />}
</div>
+14 -48
View File
@@ -15,11 +15,6 @@ export interface NotesImportResult {
provider?: string;
slots?: string[];
}
export interface NotesImportRow {
file: File;
pending: boolean;
result?: NotesImportResult;
}
/** Validate the entire response before applying any row: a malformed index
* must never attribute another file's success to this file (same names included). */
@@ -56,35 +51,26 @@ export async function postNotesImport(files: readonly File[]): Promise<NotesImpo
return parseNotesImportResults(body, files);
}
/** Files live only with the latest selection. Retry submits exactly one captured
* File, not its basename; no automatic retries or persistent import history. */
/** Only error text survives a request; selected Files stay request-local. */
export function useNotesImport(callbacks: { onStart?: () => void; onFinish?: () => void } = {}) {
const [rows, setRows] = useState<NotesImportRow[]>([]);
const [errors, setErrors] = useState<string[]>([]);
const [importing, setImporting] = useState(false);
const pending = useRef(false);
const submit = async (files: File[], retryIndex?: number) => {
const submit = async (files: File[]) => {
if (pending.current || files.length === 0) return;
pending.current = true;
setImporting(true);
if (retryIndex === undefined) setRows(files.map((file) => ({ file, pending: true })));
else setRows((prev) => prev.map((row, i) => i === retryIndex ? { file: row.file, pending: true } : row));
setErrors([]);
try {
callbacks.onStart?.();
const results = await postNotesImport(files);
setRows((prev) => {
const next = [...prev];
for (const result of results) {
const index = retryIndex ?? result.requestIndex;
next[index] = { file: files[result.requestIndex]!, pending: false, result };
}
return next;
});
setErrors(results
.filter((result) => !result.ok)
.sort((a, b) => a.requestIndex - b.requestIndex)
.map((r) => `${r.filePath}: ${r.error}${r.code ? `\n${r.code}${r.provider ? ` — ${r.provider}` : ""}${r.missing?.length ? ` — ${r.missing.join(", ")}` : ""}${r.slots?.length ? ` — ${r.slots.join(", ")}` : ""}` : ""}`));
} catch (error) {
const message = error instanceof Error ? error.message : String(error);
setRows((prev) => prev.map((row, i) => retryIndex === undefined || i === retryIndex ? {
file: row.file, pending: false,
result: { filePath: row.file.name, requestIndex: retryIndex === undefined ? i : 0, ok: false, outcome: "failed", error: message },
} : row));
setErrors(files.map((file) => `${file.name}: ${message}`));
} finally {
pending.current = false;
setImporting(false);
@@ -92,33 +78,13 @@ export function useNotesImport(callbacks: { onStart?: () => void; onFinish?: ()
}
};
return {
rows, importing,
errors, importing,
onImportFiles: (files: FileList | null) => { if (files) void submit(Array.from(files)); },
retry: (index: number) => { if (rows[index]) void submit([rows[index].file], index); },
dismiss: () => { if (!pending.current) setRows([]); },
};
}
export function NotesImportResults({ rows, importing, retry, dismiss }: Pick<ReturnType<typeof useNotesImport>, "rows" | "importing" | "retry" | "dismiss">) {
if (rows.length === 0) return null;
return (
<section aria-label="Notes import results" aria-live="polite" className="w-80 max-w-full max-h-[40vh] overflow-y-auto rounded-xl border bg-card/95 p-3 text-xs shadow-lg backdrop-blur">
<ul className="space-y-3">
{rows.map((row, i) => {
const r = row.result;
const message = row.pending ? "Importing…" : r?.outcome === "completed" ? `Import complete — ${r.stats!.nodes} new propositions, ${r.stats!.chains ?? 0} new chains.` : r?.outcome === "partial" ? "Some parts completed; others failed. Saved changes were kept." : r?.outcome === "aborted" ? "Import stopped. Any changes already saved were kept." : r?.outcome === "busy" ? "This file is already being imported. Try again when it finishes." : "Import did not complete. Any changes already saved were kept.";
return <li key={i} className="min-w-0 break-words">
<p className="font-medium">{row.file.name}</p>
<p className="text-muted-foreground">{message}</p>
{r && !r.ok && <>
<p className="whitespace-pre-wrap text-muted-foreground">{r.error}</p>
{r.code && <p className="text-muted-foreground">{r.code}{r.provider ? ` — ${r.provider}` : ""}{r.missing?.length ? ` — ${r.missing.join(", ")}` : ""}{r.slots?.length ? ` — ${r.slots.join(", ")}` : ""}</p>}
<button type="button" disabled={importing} onClick={() => retry(i)} className="mt-1 rounded-lg px-2 py-1 text-muted-foreground hover:bg-accent disabled:opacity-50">Retry</button>
</>}
</li>;
})}
</ul>
<button type="button" disabled={importing} onClick={dismiss} className="mt-3 rounded-lg px-2 py-1 text-muted-foreground hover:bg-accent disabled:opacity-50">Dismiss results</button>
</section>
);
export function NotesImportErrors({ errors }: { errors: readonly string[] }) {
return <>{errors.map((error, i) => (
<p key={i} role="alert" className="max-w-full whitespace-pre-wrap break-words text-xs text-red-400">{error}</p>
))}</>;
}
+2 -2
View File
@@ -213,7 +213,7 @@ export function SidebarToggle() {
* phases only advance (all sessions end in Teaching — phase-as-signal was
* decoration, now retired app-wide), and question-pending is the dominant
* RESTING state of real sessions — a resting state has no scan value, so
* the meta line's "Waiting for your answer" text carries it. Idle is the
* the meta line's "Waiting for input" text carries it. Idle is the
* absence of a signal, by design.
*/
function SessionStatus({ busy }: { busy: boolean }) {
@@ -250,7 +250,7 @@ export function timeAgo(iso: string, now = new Date()): string {
* ever wanted. */
function sessionMeta(chat: ChatListItem): string {
if (chat.compacting) return `Compacting context · ${timeAgo(chat.updatedAt)}`;
if (chat.pendingQuestion) return `Waiting for your answer · ${timeAgo(chat.updatedAt)}`;
if (chat.pendingQuestion) return `Waiting for input · ${timeAgo(chat.updatedAt)}`;
if ((chat.kind ?? "teach") === "practice" && chat.pendingProblem) {
return `Problem waiting · ${timeAgo(chat.updatedAt)}`;
}
+150 -20
View File
@@ -1,10 +1,44 @@
import assert from "node:assert/strict";
import { after, it } from "node:test";
import { renderToStaticMarkup } from "react-dom/server";
import { NotesImportResults, parseNotesImportResults, postNotesImport, type NotesImportResult } from "../components/notes-import.tsx";
import React, { act } from "react";
(globalThis as Record<string, unknown>).React = React;
import assert from "node:assert/strict";
import { afterEach, it } from "node:test";
import { createRoot, type Root } from "react-dom/client";
import { renderToStaticMarkup } from "react-dom/server";
import { parseHTML } from "linkedom";
import { NotesImportErrors, parseNotesImportResults, postNotesImport, useNotesImport, type NotesImportResult } from "../components/notes-import.tsx";
// Real hook/React state, isolated DOM and wholly stubbed import transport.
const dom = parseHTML("<html><body></body></html>");
Object.assign(globalThis, { window: dom.window, document: dom.document, IS_REACT_ACT_ENVIRONMENT: true });
const originalFetch = globalThis.fetch;
after(() => { globalThis.fetch = originalFetch; });
let root: Root | undefined;
let host: HTMLDivElement | undefined;
let current: ReturnType<typeof useNotesImport>;
let starts = 0;
let finishes = 0;
async function mount() {
starts = 0;
finishes = 0;
host = document.createElement("div");
document.body.appendChild(host);
root = createRoot(host);
function Harness() {
current = useNotesImport({ onStart: () => { starts++; }, onFinish: () => { finishes++; } });
return <NotesImportErrors errors={current.errors} />;
}
await act(async () => { root!.render(<Harness />); });
}
async function submit(selected: File[] | null = [...files]) {
await act(async () => { current.onImportFiles(selected as unknown as FileList | null); });
}
afterEach(async () => {
await act(async () => { root?.unmount(); });
root = undefined;
host?.remove();
host = undefined;
globalThis.fetch = originalFetch;
});
const files = [new File(["one"], "same.md"), new File(["two"], "same.md")];
const completed = (requestIndex = 0): NotesImportResult => ({ requestIndex, filePath: "same.md", ok: true, outcome: "completed", stats: { nodes: 0, chains: 0 } });
@@ -23,6 +57,11 @@ for (const [name, results] of [
["conflicting ok", [{ ...completed(), ok: false }, completed(1)]],
["invalid stats", [{ ...completed(), stats: { nodes: "bad" } }, completed(1)]],
["invalid details", [{ ...completed(), slots: [42] }, completed(1)]],
["invalid provider", [{ ...completed(), provider: 42 }, completed(1)]],
["invalid code", [{ ...completed(), code: 42 }, completed(1)]],
["invalid missing", [{ ...completed(), missing: [42] }, completed(1)]],
["invalid error", [{ ...completed(), error: 42 }, completed(1)]],
["missing failure error", [{ ...completed(), ok: false, outcome: "failed" }, completed(1)]],
] as const) it(`malformed response (${name}) is rejected for retry`, () => {
assert.throws(() => parseNotesImportResults({ results }, files), /Please retry/);
});
@@ -47,24 +86,115 @@ for (const kind of ["network", "non-JSON", "non-2xx", "malformed"] as const) it(
await assert.rejects(postNotesImport([files[0]!]));
});
for (const outcome of ["completed", "failed", "partial", "aborted", "busy"] as const) it(`renders ${outcome}, escaped filename/details, Retry and one Dismiss action`, () => {
for (const outcome of ["completed", "failed", "partial", "aborted", "busy"] as const) it(`${outcome} leaves only escaped raw failure text, without results or controls`, async () => {
const file = new File(["notes"], "<script>notes.md");
const result: NotesImportResult = { ...completed(), filePath: file.name, outcome, ok: outcome === "completed", error: "<img>synthetic failure", code: "provider_key_missing", provider: "openai", slots: ["cheap"] };
const html = renderToStaticMarkup(<NotesImportResults rows={[{ file, pending: false, result }]} importing={false} retry={() => {}} dismiss={() => {}} />);
assert.match(html, /&lt;script&gt;notes.md/);
assert.doesNotMatch(html, /<script>/);
assert.equal((html.match(/Dismiss results/g) ?? []).length, 1);
const result: NotesImportResult = { ...completed(), filePath: file.name, outcome, ok: outcome === "completed", error: "<img>synthetic failure", code: "provider_key_missing", provider: "openai", missing: ["OPENAI_API_KEY"], slots: ["cheap", "strong"] };
globalThis.fetch = async () => Response.json({ results: [result] });
await mount();
await submit([file]);
assert.equal(current.importing, false);
assert.equal(starts, 1);
assert.equal(finishes, 1);
const html = host!.innerHTML;
assert.doesNotMatch(html, /<button|<section|<ul|border|bg-card|rounded|shadow|Retry|Dismiss|Import complete|new propositions|Saved changes|Import stopped|already being imported/);
assert.deepEqual(Object.keys(current).sort(), ["errors", "importing", "onImportFiles"], "no retained rows, Files, retry or dismiss API");
if (outcome === "completed") {
assert.match(html, /Import complete — 0 new propositions, 0 new chains/); assert.doesNotMatch(html, />Retry</);
assert.equal(html, "");
assert.deepEqual(current.errors, []);
} else {
assert.match(html, />Retry</); assert.match(html, /&lt;img&gt;synthetic failure/); assert.match(html, /provider_key_missing — openai — cheap/);
assert.deepEqual(current.errors, [`${file.name}: ${result.error}\nprovider_key_missing — openai — OPENAI_API_KEY — cheap, strong`]);
assert.match(html, /&lt;script&gt;notes.md: &lt;img&gt;synthetic failure/);
assert.match(html, /provider_key_missing — openai — OPENAI_API_KEY — cheap, strong/);
assert.match(html, /role="alert"/);
assert.match(html, /text-xs text-red-400/);
assert.match(html, /whitespace-pre-wrap break-words/);
assert.doesNotMatch(html, /<script>|<img>/);
}
if (outcome === "partial") assert.match(html, /Some parts completed; others failed/);
if (outcome === "aborted") assert.match(html, /Import stopped/);
if (outcome === "busy") assert.match(html, /already being imported/);
});
it("all result actions are disabled while a local request is pending; empty results render nothing", () => {
const html = renderToStaticMarkup(<NotesImportResults rows={[{ file: files[0]!, pending: false, result: { ...completed(), ok: false, outcome: "failed", error: "test" } }]} importing retry={() => {}} dismiss={() => {}} />);
assert.equal((html.match(/disabled=""/g) ?? []).length, 2);
assert.equal(renderToStaticMarkup(<NotesImportResults rows={[]} importing={false} retry={() => {}} dismiss={() => {}} />), "");
for (const details of [
{ code: "models_not_configured", missing: ["cheap", "strong", "vision"] },
{ code: "provider_key_missing", provider: "openai", slots: ["cheap"] },
{ code: "provider_key_missing" },
{},
]) it(`keeps existing configuration detail strings (${JSON.stringify(details)})`, async () => {
globalThis.fetch = async () => Response.json({ results: [{ requestIndex: 0, filePath: "same.md", ok: false, outcome: "failed", error: "Existing raw error", ...details }] });
await mount();
await submit([files[0]!]);
const suffix = details.code === "models_not_configured" ? "\nmodels_not_configured — cheap, strong, vision" : details.provider ? "\nprovider_key_missing — openai — cheap" : details.code ? "\nprovider_key_missing" : "";
assert.deepEqual(current.errors, [`same.md: Existing raw error${suffix}`]);
});
it("empty error text renders nothing; multiple errors are plain independent alerts", () => {
assert.equal(renderToStaticMarkup(<NotesImportErrors errors={[]} />), "");
const html = renderToStaticMarkup(<NotesImportErrors errors={["one.md: failure", "two.md: failure"]} />);
assert.equal((html.match(/role="alert"/g) ?? []).length, 2);
assert.doesNotMatch(html, /<section|<button|border|bg-/);
});
it("mixed out-of-order results show only failed files in selection order, including duplicate basenames", async () => {
const selected = [new File(["success"], "success.md"), ...files];
const results: NotesImportResult[] = [
{ requestIndex: 2, filePath: "same.md", ok: false, outcome: "partial", error: "second duplicate" },
{ ...completed(), filePath: "success.md" },
{ requestIndex: 1, filePath: "same.md", ok: false, outcome: "failed", error: "first duplicate" },
];
globalThis.fetch = async () => Response.json({ results });
await mount();
await submit(selected);
assert.deepEqual(current.errors, ["same.md: first duplicate", "same.md: second duplicate"]);
assert.doesNotMatch(host!.innerHTML, /success.md|completed|propositions/);
});
for (const kind of ["network", "non-JSON", "non-2xx", "malformed", "duplicate index"] as const) it(`${kind} hook failure is visible for every selected file, never success`, async () => {
globalThis.fetch = async () => {
if (kind === "network") throw new Error("synthetic offline");
if (kind === "non-JSON") return new Response("not JSON");
if (kind === "non-2xx") return Response.json({ error: "synthetic refused" }, { status: 503 });
return Response.json({ results: kind === "duplicate index" ? [completed(), completed()] : [] });
};
await mount();
await submit();
const message = kind === "network" ? "synthetic offline" : kind === "non-2xx" ? "Import request failed (HTTP 503): synthetic refused. Please retry the file." : "Invalid import response. Please retry the file.";
assert.deepEqual(current.errors, files.map((file) => `${file.name}: ${message}`));
assert.equal(host!.querySelectorAll('[role="alert"]').length, 2);
assert.equal(finishes, 1);
assert.equal(current.importing, false);
});
it("actual attempts clear errors immediately, guard synchronous reentry, preserve callbacks and allow same-file reimport", async () => {
let requests = 0;
let resolve!: (response: Response) => void;
globalThis.fetch = async () => { requests++; return Response.json({ results: [] }); };
await mount();
await submit();
assert.equal(current.errors.length, 2);
await submit(null);
await submit([]);
assert.equal(current.errors.length, 2, "cancel/empty selection is not an attempt");
assert.equal(requests, 1);
globalThis.fetch = async () => { requests++; return new Promise<Response>((done) => { resolve = done; }); };
await act(async () => {
const staleHandler = current.onImportFiles;
staleHandler(files as unknown as FileList);
staleHandler(files as unknown as FileList);
});
assert.equal(requests, 2, "ref guard rejects even same-tick reentry before React rerenders");
assert.equal(current.importing, true);
assert.deepEqual(current.errors, []);
assert.equal(host!.innerHTML, "");
assert.equal(starts, 2);
assert.equal(finishes, 1, "finish waits for the POST");
await submit();
assert.equal(requests, 2, "pending attempts do not submit");
await act(async () => { resolve(Response.json({ results: [completed(1), completed()] })); });
assert.equal(current.importing, false);
assert.deepEqual(current.errors, []);
assert.equal(finishes, 2);
globalThis.fetch = async () => { requests++; return Response.json({ results: [completed(), completed(1)] }); };
await submit();
assert.equal(requests, 3, "same File objects can be submitted again after settlement");
assert.equal(starts, 3);
assert.equal(finishes, 3);
assert.equal(host!.innerHTML, "");
});
+19 -2
View File
@@ -58,7 +58,8 @@ describe("SessionRow", () => {
const html = render(item({ phase: "teach", pendingQuestion: true }));
assert.ok(!html.includes("session-dot"), "no dots");
assert.ok(!html.includes("braille-spinner"), "motion is reserved for working");
assert.ok(html.includes("Waiting for your answer"), "the meta line's text");
assert.ok(html.includes("Waiting for input"), "the meta line's text");
assert.ok(!html.includes("Waiting for your answer"), "old wording is gone");
});
it("a working session (turn in flight) renders the braille spinner — the ONLY indicator", () => {
@@ -82,7 +83,7 @@ describe("SessionRow", () => {
it("the meta line: state replaces the count when the state is the useful fact", () => {
const awaiting = render(item({ pendingQuestion: true, updatedAt: "2026-01-02T01:00:00.000Z" }));
assert.ok(awaiting.includes("Waiting for your answer · "), "awaiting meta");
assert.ok(awaiting.includes("Waiting for input · 2026-01-02"), "awaiting meta keeps the existing date");
assert.ok(!awaiting.includes("messages"), "count yields to the state");
assert.ok(!awaiting.includes("braille-spinner"), "…and the spinner stays off");
@@ -97,6 +98,22 @@ describe("SessionRow", () => {
assert.match(idle, /\d{4}-\d{2}-\d{2}/, "idle shows the ISO date");
});
it("pending questions use the same wording for teach and practice with recent and old dates", () => {
for (const kind of ["teach", "practice"] as const) {
for (const updatedAt of [new Date().toISOString(), "2025-06-02T12:00:00.000Z"]) {
const html = render(item({ kind, pendingQuestion: true, updatedAt }));
assert.ok(html.includes(`Waiting for input · ${timeAgo(updatedAt)}`));
assert.ok(!html.includes("Waiting for your answer"));
}
}
});
it("compacting retains priority over pending input", () => {
const html = render(item({ compacting: true, pendingQuestion: true }));
assert.match(html, /Compacting context ·/);
assert.doesNotMatch(html, /Waiting for input/);
});
it("active row is visually marked by the background alone (owner, round 5: no weight change)", () => {
const html = render(item({}), true);
assert.ok(html.includes("bg-accent"), "active background");